Fix undefined trackGaEvent and give row download buttons a busy state - #76
Merged
Jingxi-Polymaker merged 2 commits intoSep 10, 2026
Merged
Conversation
The LayerHub banner CTA called trackGaEvent, which is not defined anywhere in the project, so every click threw a ReferenceError and the banner_explore event was never recorded. Route it through trackUsageEvent like every other event in app.js, which already swallows provider failures. Row download buttons (JSON, BambuStudio JSON, .bbsflmt) fetch and sometimes zip before the browser saves a file, with no feedback for the whole wait and no guard against a repeat click. The bulk Download Selected / Download Bundle buttons already disable themselves and show a loading label; the per-row ones now get the equivalent through an is-busy class, aria-busy, and a spinner that works in both themes and respects prefers-reduced-motion. Generated-By: PostHog Desktop Task-Id: bab76398-4c5b-411a-812f-ebc00953b582
Jingxi-Polymaker
marked this pull request as ready for review
September 10, 2026 08:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LayerHub banner called an undefined tracking function, and row downloads gave no feedback while fetching or packaging files. This change routes the banner event through
trackUsageEventand gives JSON and.bbsflmtrow buttons a busy state with repeat-click protection.Bundle downloads now stay busy through mapping, confirmation dialogs, and ZIP generation. Completion, cancellation, and errors all clear the state; ZIP failures reach the download error handler. The action column has enough space for both buttons and busy indicators instead of clipping the bundle button. The spinner supports both themes and reduced motion.
Validation:
npm run test:all: 260 tests pass..bbsflmtdownload and validated its archive and all three JSON entries.